Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFT Metadata Crawler] Add metrics to parser #9602

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

just-in-chang
Copy link
Contributor

@just-in-chang just-in-chang commented Aug 10, 2023

Description

Add some metrics to the parser

Metrics

  • PARSER_INVOCATIONS_COUNT
  • PARSER_SUCCESSES_COUNT
  • PARSER_FAIL_COUNT
  • PUBSUB_STREAM_RESET_COUNT
  • PUBSUB_ACK_SUCCESS_COUNT
  • UNABLE_TO_GET_CONNECTION_COUNT
  • GOT_CONNECTION_COUNT
  • DUPLICATE_TOKEN_URI_COUNT
  • DUPLICATE_RAW_IMAGE_URI_COUNT
  • DUPLICATE_RAW_ANIMATION_URI_COUNT
  • SKIP_URI_COUNT
  • PARSE_URI_INVOCATION_COUNT
  • PARSE_URI_TYPE_COUNT
  • PARSE_JSON_INVOCATION_COUNT
  • SUCCESSFULLY_PARSED_JSON_COUNT
  • FAILED_TO_PARSE_JSON_COUNT
  • OPTIMIZE_IMAGE_INVOCATION_COUNT
  • OPTIMIZE_IMAGE_TYPE_COUNT
  • SUCCESSFULLY_OPTIMIZED_IMAGE_COUNT
  • FAILED_TO_OPTIMIZE_IMAGE_COUNT
image

@just-in-chang just-in-chang force-pushed the justin/metrics branch 9 times, most recently from 8c46a9d to e341160 Compare August 29, 2023 00:49
@just-in-chang just-in-chang enabled auto-merge (squash) August 29, 2023 22:25
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.6.2 ==> 06061046357bb1382855d26411e52888ea780d16

Compatibility test results for aptos-node-v1.6.2 ==> 06061046357bb1382855d26411e52888ea780d16 (PR)
1. Check liveness of validators at old version: aptos-node-v1.6.2
compatibility::simple-validator-upgrade::liveness-check : committed: 4094 txn/s, latency: 7090 ms, (p50: 6600 ms, p90: 9300 ms, p99: 18300 ms), latency samples: 176080
2. Upgrading first Validator to new version: 06061046357bb1382855d26411e52888ea780d16
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1778 txn/s, latency: 15832 ms, (p50: 19300 ms, p90: 21800 ms, p99: 22500 ms), latency samples: 92500
3. Upgrading rest of first batch to new version: 06061046357bb1382855d26411e52888ea780d16
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1805 txn/s, latency: 16310 ms, (p50: 18900 ms, p90: 22300 ms, p99: 22600 ms), latency samples: 93900
4. upgrading second batch to new version: 06061046357bb1382855d26411e52888ea780d16
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3216 txn/s, latency: 9806 ms, (p50: 9900 ms, p90: 13300 ms, p99: 13900 ms), latency samples: 138320
5. check swarm health
Compatibility test for aptos-node-v1.6.2 ==> 06061046357bb1382855d26411e52888ea780d16 passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 06061046357bb1382855d26411e52888ea780d16

two traffics test: inner traffic : committed: 6577 txn/s, latency: 5963 ms, (p50: 5700 ms, p90: 7300 ms, p99: 11100 ms), latency samples: 2841660
two traffics test : committed: 100 txn/s, latency: 3057 ms, (p50: 3100 ms, p90: 3700 ms, p99: 4300 ms), latency samples: 1840
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.268, avg: 0.218", "QsPosToProposal: max: 0.161, avg: 0.148", "ConsensusProposalToOrdered: max: 0.624, avg: 0.570", "ConsensusOrderedToCommit: max: 0.512, avg: 0.497", "ConsensusProposalToCommit: max: 1.095, avg: 1.067"]
Max round gap was 1 [limit 4] at version 1468646. Max no progress secs was 3.798275 [limit 10] at version 1468646.
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.5.1 ==> 06061046357bb1382855d26411e52888ea780d16

Compatibility test results for aptos-node-v1.5.1 ==> 06061046357bb1382855d26411e52888ea780d16 (PR)
Upgrade the nodes to version: 06061046357bb1382855d26411e52888ea780d16
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4778 txn/s, latency: 6681 ms, (p50: 6300 ms, p90: 10200 ms, p99: 13500 ms), latency samples: 181580
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> 06061046357bb1382855d26411e52888ea780d16 passed
Test Ok

@just-in-chang just-in-chang merged commit 6ff5977 into main Aug 29, 2023
71 of 73 checks passed
@just-in-chang just-in-chang deleted the justin/metrics branch August 29, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants