Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opencontainers image-spec to Dockerfile #128

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Add opencontainers image-spec to Dockerfile #128

merged 1 commit into from
Aug 8, 2022

Conversation

SauravMaheshkar
Copy link
Contributor

Congratulations on the release !! 🥳 🍾

This PR makes a few tiny changes to improve the overall quality of the docker image 🐳


For reference more annotations can be found here

@SauravMaheshkar
Copy link
Contributor Author

Request for Review: @decarboxy @gahdritz

@gahdritz
Copy link
Collaborator

gahdritz commented Jul 1, 2022

Could you summarize what this does?

@SauravMaheshkar
Copy link
Contributor Author

Sure, Opencontainers is a open governance structure dedicated to creating open standards around container technology and has defined a "open-review" image annotations that can be added to Images to improve the overall quality of the Dockerfile.

The purpose of this PR is to add said annotations that make the Image follow these said formal specifications.

They can be thought of as metadata for the Dockerfile that have no effect on the Image but at the same time provides extra context.

@SauravMaheshkar
Copy link
Contributor Author

Thoughts @gahdritz?

@gahdritz gahdritz merged commit 7aa0709 into aqlaboratory:main Aug 8, 2022
@SauravMaheshkar SauravMaheshkar deleted the patch-1 branch August 8, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants