squash! check windowsBits === 8 early

aqrln · May 18, 2017 · bf63a37 · lpinca · May 18, 2017 · aqrln
1 parent c5f18b1
commit bf63a37
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/lib/zlib.js b/lib/zlib.js
@@ -193,6 +193,10 @@ class Zlib extends Transform {
           opts.windowBits > constants.Z_MAX_WINDOWBITS) {
         throw new RangeError('Invalid windowBits: ' + opts.windowBits);
       }
+      if (mode === constants.DEFLATERAW &&
+          opts.windowBits === 8) {
+        throw new RangeError('Unsupported windowBits for DeflateRaw: 8');
+      }
     }
 
     if (opts.level) {

diff --git a/test/parallel/test-zlib-failed-init.js → ...st-zlib-deflate-unsupported-windowbits.js b/test/parallel/test-zlib-failed-init.js → ...st-zlib-deflate-unsupported-windowbits.js
@@ -10,4 +10,4 @@ const zlib = require('zlib');
 // (http://zlib.net/manual.html#Advanced)
 assert.throws(() => {
   zlib.createDeflateRaw({ windowBits: 8 });
-}, /^Error: Init error$/);
+}, /^RangeError: Unsupported windowBits for DeflateRaw: 8$/);