Process element highlight correctly (#137)

fixes #128
aquality-automation · Feb 23, 2024 · aa6e2ba · aa6e2ba
1 parent 9751590
commit aa6e2ba
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/src/main/java/aquality/selenium/elements/Element.java b/src/main/java/aquality/selenium/elements/Element.java
@@ -131,7 +131,7 @@ public String getText() {
     @Override
     public String getText(HighlightState highlightState) {
         logElementAction("loc.get.text");
-        getJsActions().highlightElement();
+        getJsActions().highlightElement(highlightState);
         String value = doWithRetry(() -> getElement().getText());
         logElementAction("loc.text.value", value);
         return value;
@@ -147,7 +147,7 @@ public IElementStateProvider state() {
     @Override
     public String getAttribute(final String attr, HighlightState highlightState) {
         logElementAction("loc.el.getattr", attr);
-        getJsActions().highlightElement();
+        getJsActions().highlightElement(highlightState);
         String value = doWithRetry(() -> getElement().getAttribute(attr));
         logElementAction("loc.el.attr.value", attr, value);
         return value;
@@ -156,7 +156,7 @@ public String getAttribute(final String attr, HighlightState highlightState) {
     @Override
     public String getCssValue(final String propertyName, HighlightState highlightState) {
         logElementAction("loc.el.cssvalue", propertyName);
-        getJsActions().highlightElement();
+        getJsActions().highlightElement(highlightState);
         String value = doWithRetry(() -> getElement().getCssValue(propertyName));
         logElementAction("loc.el.attr.value", propertyName, value);
         return value;

diff --git a/src/main/java/aquality/selenium/elements/actions/JsActions.java b/src/main/java/aquality/selenium/elements/actions/JsActions.java
@@ -71,7 +71,8 @@ public void highlightElement() {
      * Highlights the element.
      */
     public void highlightElement(HighlightState highlightState) {
-        if (AqualityServices.getBrowserProfile().isElementHighlightEnabled() || highlightState.equals(HighlightState.HIGHLIGHT)) {
+        if ((AqualityServices.getBrowserProfile().isElementHighlightEnabled() && !highlightState.equals(HighlightState.NOT_HIGHLIGHT))
+                || highlightState.equals(HighlightState.HIGHLIGHT)) {
             executeScript(JavaScript.BORDER_ELEMENT);
         }
     }

diff --git a/src/test/java/tests/usecases/BrowserConcurrencyTests.java b/src/test/java/tests/usecases/BrowserConcurrencyTests.java
@@ -40,7 +40,7 @@ public void testShouldBePossibleToUseParallelStreams(){
         textBoxes.parallelStream().forEach(lbl -> {
             // set the same instance of browser for all threads
             AqualityServices.setBrowser(browser);
-            String text = lbl.getText(HighlightState.HIGHLIGHT);
+            String text = lbl.getText(HighlightState.NOT_HIGHLIGHT);
             // processing results of work trough web driver (getting text)
             String updatedText = text  + "_updated";
             texts.add(text);