Modification: Modified to generate PASS if no secrets (#621)

* Added AWS 'Secrets Manager Secret Rotation Enabled' plugin and test cases * Modified to generate PASS if no secrets Co-authored-by: Gio Rodriguez <gioroddev@gmail.com>
aquasecurity · Mar 29, 2021 · 64986c6 · 64986c6
1 parent 956bf2e
commit 64986c6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/plugins/aws/secretsmanager/secretRotationEnabled.js b/plugins/aws/secretsmanager/secretRotationEnabled.js
@@ -38,7 +38,7 @@ module.exports = {
             }
 
             if (!listSecrets.data.length) {
-                helpers.addResult(results, 2, 'Secrets Manager is not in use', region);
+                helpers.addResult(results, 0, 'No secrets found', region);
                 return rcb();
             }
 

diff --git a/plugins/aws/secretsmanager/secretRotationEnabled.spec.js b/plugins/aws/secretsmanager/secretRotationEnabled.spec.js
@@ -143,11 +143,11 @@ describe('secretRotationEnabled', function () {
             });
         });
 
-        it('should PASS if Secrets Manager is not in use', function (done) {
+        it('should PASS if no secrets found', function (done) {
             const cache = createCache([]);
             secretRotationEnabled.run(cache, {}, (err, results) => {
                 expect(results.length).to.equal(1);
-                expect(results[0].status).to.equal(2);
+                expect(results[0].status).to.equal(0);
                 expect(results[0].region).to.equal('us-east-1');
                 done();
             });