Created plugin for ecs encryption enabled #1427
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Phaedra Solutions seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Phaedra Solutions seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
alphadev4
reviewed
Oct 21, 2022
alphadev4
reviewed
Oct 21, 2022
alphadev4
requested changes
Oct 21, 2022
| } | ||
|
|
||
| const cluster = describeCluster.data.clusters[0]; | ||
| let containerEncryptionEnabled = (cluster.configuration?.executeCommandConfiguration?.KmsKeyId) ? true : false; |
There was a problem hiding this comment.
Suggested change
| let containerEncryptionEnabled = (cluster.configuration?.executeCommandConfiguration?.KmsKeyId) ? true : false; | |
| let containerEncryptionEnabled = (cluster.configuration && cluster.configuration.executeCommandConfiguration && cluster.configuration.executeCommandConfiguration.KmsKeyId) ? true : false; |
There was a problem hiding this comment.
not using chaining operator as for now
| domain: 'Container', | ||
| description: 'Ensure that ECS clusters have encryption feature enabled.', | ||
| more_info: 'Encrypt the data between the local client and the container.', | ||
| recommended_action: 'Enabled container encryption feature for ECS clusters by using aws cli and run the command.', |
There was a problem hiding this comment.
Suggested change
| recommended_action: 'Enabled container encryption feature for ECS clusters by using aws cli and run the command.', | |
| recommended_action: 'Enable container encryption feature for ECS clusters.', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.