Feature/cloudsploit gcp new rules p1 #1455
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is causing alarms to be open and close every day.
auditConfigurationLogging - supports filter in more than one line - supports double/single quotes and no quotes at all when there are no special characters in strings - supports filter when there are multiple spaces between words customRoleLogging - supports filter in more than one line - supports double/single quotes and no quotes at all when there are no special characters in strings - supports filter when there are multiple spaces between words projectOwnershipLogging - supports double/single quotes and no quotes at all when there are no special characters in strings - supports filter when there are multiple spaces between words sqlConfigurationLogging - supports double/single quotes storagePermissionsLogging - supports filter in more than one line - supports double/single quotes and no quotes at all when there are no special characters in strings - supports filter when there are multiple spaces between words vpcFirewallRuleLogging - added a missing payload method to the test - supports double/single quotes and no quotes at all when there are no special characters in strings - supports filter when there are multiple spaces between words vpcNetworkLogging - supports double/single quotes and no quotes at all when there are no special characters in strings - supports filter when there are multiple spaces between words vpcNetworkRouteLogging - supports double/single quotes and no quotes at all when there are no special characters in strings - supports filter when there are multiple spaces between words
2 API rules 2 Compute rules 1 kms rule 2 sql rules 10 network rules Updated collector.js with new collectors Updated export.js with the new rules Update regions.js with the scopes for the new collectors
2 API rules 2 Compute rules 1 kms rule 2 sql rules 10 network rules Updated collector.js with new collectors Updated export.js with the new rules Update regions.js with the scopes for the new collectors
|
hi @mcplima can you please resolve the conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New GCP Rules - Cloudsploit - Part 1 (all rules with DOCs on Zanshin)
2 API rules
2 Compute rules
1 kms rule
2 sql rules
10 network rules
Updated collector.js with new collectors
Updated export.js with the new rules
Updated regions.js with the scopes for the new collectors
All these rules where documented previously on Zanshin. They refer to an update done to Cloudsploit 6 months ago.