alb security groups plugin #1555
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehakseedat63
requested changes
Jun 5, 2023
mehakseedat63
requested changes
Jun 6, 2023
mehakseedat63
requested changes
Jun 6, 2023
|
|
||
| for (let alb of describeLoadBalancers.data){ | ||
|
|
||
| if (!alb.LoadBalancerArn || (!alb.Type && alb.Type.toLowerCase() === 'application')) continue; |
There was a problem hiding this comment.
Suggested change
| if (!alb.LoadBalancerArn || (!alb.Type && alb.Type.toLowerCase() === 'application')) continue; | |
| if (!alb.LoadBalancerArn || (!alb.Type && alb.Type.toLowerCase() === 'application')) continue; |
This check will break if loadBalancerArn exists and type doesn't, is it supposed to be 'alb.Type && alb.Type.toLowerCase()'?
…into feature/SAAS-14034-aws-ensure-application-load-balancers-are-associated-with-security-group
alphadev4
reviewed
Dec 5, 2023
alphadev4
reviewed
Dec 5, 2023
alphadev4
reviewed
Dec 5, 2023
alphadev4
reviewed
Dec 5, 2023
alphadev4
reviewed
Dec 5, 2023
alphadev4
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.