backup vault role level access #1593
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkhtarAmir
suggested changes
Apr 4, 2023
| title: 'Backup Vault Role Access', | ||
| category: 'Backup', | ||
| domain: 'Storage', | ||
| description: 'Ensure that AWS Backup Vault are accessed through roles.', |
There was a problem hiding this comment.
Suggested change
| description: 'Ensure that AWS Backup Vault are accessed through roles.', | |
| description: 'Ensure that AWS Backup vaults are accessed through roles.', |
| if (getBackupVaultAccessPolicy && getBackupVaultAccessPolicy.err && getBackupVaultAccessPolicy.err.code && | ||
| getBackupVaultAccessPolicy.err.code == 'ResourceNotFoundException') { | ||
| helpers.addResult(results, 2, | ||
| 'No access policy found for Backup vault', region, resource); |
There was a problem hiding this comment.
doesn't it mean no access?
| helpers.addResult(results, 0, | ||
| 'The Backup Vault policy does not have trust relationship statements', | ||
| region, resource); | ||
| return; |
There was a problem hiding this comment.
Suggested change
| return; | |
| continue; |
| continue; | ||
| } | ||
|
|
||
| if (!getBackupVaultAccessPolicy || getBackupVaultAccessPolicy.err || !getBackupVaultAccessPolicy.data) { |
There was a problem hiding this comment.
Suggested change
| if (!getBackupVaultAccessPolicy || getBackupVaultAccessPolicy.err || !getBackupVaultAccessPolicy.data) { | |
| if (!getBackupVaultAccessPolicy || getBackupVaultAccessPolicy.err || !getBackupVaultAccessPolicy.data || !getBackupVaultAccessPolicy.data.Policy) { |
| var actions = []; | ||
| let roleAccess = true; | ||
| for (var statement of statements) { | ||
| var principalEval = helpers.globalPrincipal(statement.Principal); |
There was a problem hiding this comment.
why does it have to be global principal?
|
|
||
| if (!roleAccess) { | ||
| helpers.addResult(results, 2, | ||
| 'Backup Vault does not have role level access only' + actions, |
There was a problem hiding this comment.
Isn't actions list empty?
alphadev4
reviewed
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.