Feature/plugin/iam/less restrictive iam role policies #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mRolePolicies behavior
…ugin. additionally test cases added for both existing and added functionality.
…etting; revision of test cases associated with this setting and associated plugin
… with federated users
|
|
giorod3
requested changes
Sep 3, 2020
Comment on lines
+6
to
+16
| function hasFederatedUserRole(policyDocument) { | ||
| // true iff every statement refers to federated user access | ||
| let statement; | ||
| for (statement of policyDocument.Statement) { | ||
| if (statement.Action !== 'sts:AssumeRoleWithSAML' && statement.Action !== 'sts:AssumeRoleWithWebIdentity'){ | ||
| return false; | ||
| } | ||
| } | ||
| return true; | ||
| } | ||
|
|
There was a problem hiding this comment.
can you move this function to our helpers file: https://github.com/cloudsploit/scans/blob/master/helpers/aws/functions.js
and just import the file like this: var helpers = require('../../../helpers/aws');
|
Added separate PR for this, can be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds options to ignore roles for SAML/IDP assumption. Adds option to ignore service:* permissions
These plugins were developed by Trek10 under contract to WarnerMedia for release back into the main CloudSploit Scanning Engine. WarnerMedia expressly authorizes their contribution.