feature/10 | Added IAM Trusted Cross-Account Roles plugin, spec file #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wizard-security-groups Feature/ec2 plugin mark launch wizard security groups
…ture/SPLOIT-113
Feature/sploit 113
SPLOIT-113: Updated custom settings
SPLOIT-113: Added regex to check if NoEcho is enabled
giorod3
approved these changes
Oct 5, 2020
matthewdfuller
suggested changes
Oct 19, 2020
AkhtarAmir
force-pushed
the
feature/10
branch
from
4c12a88
to
a03fff6
Compare
giorod3
reviewed
Nov 25, 2020
giorod3
reviewed
Nov 25, 2020
giorod3
requested changes
Nov 25, 2020
dipsubha06
reviewed
Jan 20, 2021
| helpers.addResult(results, 2, | ||
| `Cross-account role "${role.RoleName}" contains these untrusted account principals: ${restrictedAccountPrincipals.join(', ')}`, | ||
| 'global', role.Arn); | ||
| } |
There was a problem hiding this comment.
Do we not need any else condition?
|
This PR has been split and regenerated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.