Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix/vmAvailabilitySetLimit: Fixed bug and added test case #696

Merged
merged 20 commits into from
Jul 30, 2021

Conversation

ali-imran7
Copy link
Contributor

No description provided.

@ali-imran7
Copy link
Contributor Author

This PR addresses a bug for this plugin.
Bug Description : Plugin was generating always passing results
RCA: availabilitySets:listBySubscription api call returns 0 for virtual machines count in the availability set. Thats why plugin was always generating passing result.

@giorod3 giorod3 added the readytogo PRs ready to merge label Jun 1, 2021
ali-imran7 and others added 15 commits June 3, 2021 17:47
…ases (aquasecurity#640)

* feature/AKD-132: Added Azure 'Premium SSD Disabled' plugin and test cases

* feature/AKD-132: Added Azure 'Premium SSD Disabled' plugin and test cases

* Update plugins/azure/virtualmachines/premiumSsdDisabled.js

Co-authored-by: Gio Rodriguez <gioroddev@gmail.com>

* feature/AKD-132: Added Azure 'Premium SSD Disabled' plugin and test cases

Co-authored-by: AkhtarAmir <31914988+AkhtarAmir@users.noreply.github.com>
Co-authored-by: Gio Rodriguez <gioroddev@gmail.com>
aquasecurity#741)

* feature/AKD-189: Added Azure 'Always On Enabled' Plugin and test cases

* feature/AKD-189: Added Azure 'Always On Enabled' Plugin and test cases

* Update plugins/azure/appservice/alwaysOnEnabled.js

Co-authored-by: Gio Rodriguez <gioroddev@gmail.com>
…Plugin and test cases (aquasecurity#734)

* feature/networkPeering: Added Azure 'Managed NAT Gateway In Use' Plugin and test cases

* feature/networkPeering: Added Azure 'Managed NAT Gateway In Use' Plugin and test cases

* feature/managedNatGateways: Added Azure 'Managed NAT Gateway In Use' Plugin and test cases
…est cases (aquasecurity#739)

* feature/AKD-188: Added Azure 'Remote Debugging Disabled' Plugin and test cases

* feature/AKD-188: Added Azure 'Remote Debugging Disabled' Plugin and test cases

* feature/AKD-188: Added Azure 'Remote Debugging Disabled' Plugin and test cases

Co-authored-by: Gio Rodriguez <gioroddev@gmail.com>
…tions' Plugin and test cases (aquasecurity#721)

* feature/noGatewayConnections: Added Azure 'No Network Gateways Connections' Plugin and test cases

* feature/noGatewayConnections: Added Azure 'No Network Gateways Connections' Plugin and test cases

Co-authored-by: Gio Rodriguez <gioroddev@gmail.com>
…d test cases (aquasecurity#720)

* feature/gatewaysInUse: Added Azure 'Network Gateways Usage' Plugin and test cases

* feature/gatewaysInUse: Added Azure 'Network Gateways Usage' Plugin and test cases

Co-authored-by: Gio Rodriguez <gioroddev@gmail.com>
…lugin and test cases (aquasecurity#716)

* feature/AKD-149: Added Azure 'Disk Volumes BYOK Encryption Enabled' plugin and test cases

* feature/AKD-149: Added Azure 'Disk Volumes BYOK Encryption Enabled' plugin and test cases
…lugin and test cases (aquasecurity#715)

* feature/AKD-143: Added Azure 'Scale Sets Health Monitoring Enabled' plugin and test cases

* feature/AKD-144: Added Azure 'Scale Sets Health Monitoring Enabled' plugin and test cases

Co-authored-by: Gio Rodriguez <gioroddev@gmail.com>
…d' plugin and test cases (aquasecurity#714)

* feature/AKD-143: Added Azure 'Virtual Machine Boot Diagnostics Enabled' plugin and test cases

* feature/AKD-143: Added Azure 'Virtual Machine Boot Diagnostics Enabled' plugin and test cases

Co-authored-by: Gio Rodriguez <gioroddev@gmail.com>
… Enabled' plugin and test cases (aquasecurity#713)

* feature/AKD-141: Added Azure 'Virtual Machine Performance Diagnostics Enabled' plugin and test cases

* feature/AKD-141: Added Azure 'Virtual Machine Performance Diagnostics Enabled' plugin and test cases

* feature/AKD-141: Added Azure 'Virtual Machine Performance Diagnostics Enabled' plugin and test cases

Co-authored-by: Gio Rodriguez <gioroddev@gmail.com>
…abled' plugin and test cases (aquasecurity#712)

* feature/AKD-142: Added 'Azure Active Directory (AD) Authentication Enabled' plugin and test cases

* feature/AKD-142: Added 'Azure Active Directory (AD) Authentication Enabled' plugin and test cases

Co-authored-by: Gio Rodriguez <gioroddev@gmail.com>
…quasecurity#681)

* spec: Added test case file for 'VM Agent Enabled' plugin

* spec/virtualMachines: Added test cases for virtual machine plugins
…cases (aquasecurity#668)

* feature/AKD-147: Added Azure 'Old VM Disk Snapshots' plugin and test cases

* feature/AKD-147: Added Azure 'Old VM Disk Snapshots' plugin and test cases

Co-authored-by: AkhtarAmir <makhtar.pucit@gmail.com>
Co-authored-by: Gio Rodriguez <gioroddev@gmail.com>
@giorod3 giorod3 merged commit b8cd03f into aquasecurity:master Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
readytogo PRs ready to merge reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants