Modify 1.2.3 Ensure that the DenyServiceExternalIPs is set in CIS-1.7/1.8
#1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andypitcher
changed the title
1.2.3 Ensure that the DenyServiceExternalIPs is set in CIS-1.7/1.8
2 tasks
andypitcher
force-pushed
the
fix-master-1.2.3-DenyServiceExternalIPs
branch
from
2edf840
to
e2184fb
Compare
|
@mozillazg could you review this ? For context, this issue has been added in CIS Workbench for 1.10 Milestone |
mozillazg
approved these changes
Jul 27, 2024
|
@chen-keinan ping~ |
- op changed from `have` to `has` and removed bin_op: or - remediation description changed to only include --enable-admission-plugins
andypitcher
force-pushed
the
fix-master-1.2.3-DenyServiceExternalIPs
branch
from
2a071f0
to
2a8c05e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent: #1606
Context: In CIS-1.7 and CIS-1.8 (master
1.2.3 Ensure that the DenyServiceExternalIPs is set) the operand is wrong and makes the check to WARN even if--enable-admission-plugins=DenyServiceExternalIPsis properly set.This PR makes the following change to master 1.2.3 check for
CIS-1.7andCIS-1.8:havetohasand removedbin_op: or--enable-admission-plugins