CIS 1.9 - Fix incorrectly failing tests 1.1.13 and 1.1.14 #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for your contribution! How about #1649 ? |
This was referenced Aug 20, 2024
|
@cskarby FYI, this is still not working when run inside a pod using |
emosbaugh
reviewed
Sep 24, 2024
| @@ -189,7 +189,7 @@ groups: | |||
| - id: 1.1.13 | |||
| text: "Ensure that the default administrative credential file permissions are set to 600 (Automated)" | |||
| audit: | | |||
| for adminconf in /etc/kubernetes/{admin.conf,super-admin.conf}; do if test -e $adminconf; then stat -c \"permissions=%a %n\" $adminconf; fi; done | |||
| for adminconf in /etc/kubernetes/{admin.conf,super-admin.conf}; do if test -e $adminconf; then stat -c "permissions=%a %n" $adminconf; fi; done | |||
There was a problem hiding this comment.
i do not think this will work because curly brace expansion is a feature of bash and this is run with sh
Line 299 in f8b6f2f
for example
ethan@ethanm-kurl-1:~$ echo 'for adminconf in /etc/kubernetes/{admin.conf,super-admin.conf}; do if test -e $adminconf; then stat -c "ownership=%U:%G %n" $adminconf; fi; done' | sh
ethan@ethanm-kurl-1:~$ echo 'for adminconf in /etc/kubernetes/{admin.conf,super-admin.conf}; do if test -e $adminconf; then stat -c "ownership=%U:%G %n" $adminconf; fi; done' | bash
ownership=root:root /etc/kubernetes/admin.conf
ownership=root:root /etc/kubernetes/super-admin.conf
emosbaugh
reviewed
Sep 24, 2024
| @@ -207,7 +207,7 @@ groups: | |||
| - id: 1.1.14 | |||
| text: "Ensure that the default administrative credential file ownership is set to root:root (Automated)" | |||
| audit: | | |||
| for adminconf in /tmp/{admin.conf,super-admin.conf}; do if test -e $adminconf; then stat -c "ownership=%U:%G %n" $adminconf; fi; done | |||
| for adminconf in /etc/kubernetes/{admin.conf,super-admin.conf}; do if test -e $adminconf; then stat -c "ownership=%U:%G %n" $adminconf; fi; done | |||
|
IMO This PR can be close, since #1649 has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.