Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VEX related improvements in the build process #1768

Merged
merged 1 commit into from
Jan 13, 2025
Merged

VEX related improvements in the build process #1768

merged 1 commit into from
Jan 13, 2025

Conversation

macedogm
Copy link
Contributor

This PR solves #1767 by compiling against the build directory instead of main.go. This will add the proper package path inside the binary and allow VEX entries to be matched against the kube-bench binary.

> go version -m dist/kube-bench | head -n 3
dist/kube-bench: go1.23.4
	path	github.com/aquasecurity/kube-bench
	mod	github.com/aquasecurity/kube-bench	(devel)

@macedogm
Copy link
Contributor Author

PTAL @afdesk and @andypitcher

afdesk
afdesk approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@afdesk afdesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks!

@macedogm
VEX related improvements in the build process
cbbaba1 
Signed-off-by: Guilherme Macedo <guilherme@gmacedo.com>
@macedogm macedogm force-pushed the vex-go-build-improvements branch from 910084a to cbbaba1 Compare January 10, 2025 11:53
@macedogm
Copy link
Contributor Author

I rebased the PR.

mozillazg
mozillazg approved these changes Jan 11, 2025
View reviewed changes
Copy link
Collaborator

@mozillazg mozillazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@afdesk afdesk merged commit fd5e2c1 into aquasecurity:main Jan 13, 2025
5 checks passed
@macedogm macedogm deleted the vex-go-build-improvements branch January 13, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afdesk afdesk afdesk approved these changes

@andypitcher andypitcher andypitcher approved these changes

@mozillazg mozillazg mozillazg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@macedogm @mozillazg @andypitcher @afdesk