-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Program GetFd() return type #51
Comments
If you agree I can raise a PR for both. |
Agree. Let's change this to return an int like BPFMap. |
Sure, let's consider libbpfgo and tracee independent. Currently I'm checking libbpfgo changes for tracee (specially GetMap, UpdateMap) and I can see that the new implementations of:
are the only functions having unsafe.Pointer() as arguments: Users have to specify C types as arguments instead of relying in old interface{} arguments (that had issues). All the rest of functions seem to have go types as arguments. All of them return go types.
We may need to review return types, so all functions return Go types. @geyslan in your PR, could you re-check if all functions are returning go types (not only GetFD) ? Thanks! |
I've detected |
Should we return a Go int instead of C.int?
libbpfgo/libbpfgo.go
Lines 650 to 652 in 871dc67
Like this:
libbpfgo/libbpfgo.go
Lines 466 to 468 in 871dc67
The text was updated successfully, but these errors were encountered: