chore: call bpf_object__open_mem from go #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes libbpfgo to call bpf_object__open_mem directly from go instead of doing this via a C wrapper. What this means is that we maintained opts creation in C, but the actual libbpf object open call is done in go. This creates two new functions in libbpfgo.h as helpers: - bpf_object_open_opts_new() - bpf_object_open_opts_free() Context: #304 Additionally, this commit enforces the use of defer and resolves a potential CKconfigPath leak when len(args.KConfigFilePath) is > 2.
|
This is a rebase to #314 (which I'm +1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes libbpfgo to call bpf_object__open_mem directly from go instead of doing this via a C wrapper. What this means is that we maintained opts creation in C, but the actual libbpf object open call is done in go.
This creates two new functions in libbpfgo.h as helpers:
Context: #304
Additionally, this commit enforces the use of defer and resolves a potential CKconfigPath leak when len(args.KConfigFilePath) is > 2.