Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SkipMemlockBump to NewModuleArgs #337

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

bobrik
Copy link
Contributor

@bobrik bobrik commented Jul 4, 2023

Unconditionally bumping rlimit requires CAP_SYS_RESOURCE, which can be avoided on newer kernels where memcg is responsible for bpf memory limits.

See: #265.

Unconditionally bumping rlimit requires `CAP_SYS_RESOURCE`, which can be
avoided on newer kernels where memcg is responsible for bpf memory limits.
@CLAassistant
Copy link

CLAassistant commented Jul 4, 2023

CLA assistant check
All committers have signed the CLA.

@bobrik
Copy link
Contributor Author

bobrik commented Jul 18, 2023

@rafaeldtinoco, @geyslan, is there anything I can do to move this forward?

Copy link
Member

@geyslan geyslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bobrik, thanks for your contribution. I have a question.

libbpfgo.go Show resolved Hide resolved
@rafaeldtinoco rafaeldtinoco self-requested a review July 19, 2023 20:49
Copy link
Contributor

@rafaeldtinoco rafaeldtinoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaeldtinoco rafaeldtinoco merged commit 7e47ce8 into aquasecurity:main Jul 24, 2023
javierhonduco referenced this pull request in parca-dev/parca-agent Sep 15, 2023
…-libbpf-1.2 (#2013)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[github.com/aquasecurity/libbpfgo](https://github.com/aquasecurity/libbpfgo)
| require | minor | `v0.4.9-libbpf-1.2.0.0.20230817212518-21cf435d454e`
-> `v0.5.0-libbpf-1.2` |

---

### Release Notes

<details>
<summary>aquasecurity/libbpfgo
(github.com/aquasecurity/libbpfgo)</summary>

###
[`v0.5.0-libbpf-1.2`](https://github.com/aquasecurity/libbpfgo/releases/tag/v0.5.0-libbpf-1.2)

#### What's Changed

- revive: update revive rules by
[@&#8203;rafaeldtinoco](https://github.com/rafaeldtinoco) in
[https://github.com/aquasecurity/libbpfgo/pull/333](https://github.com/aquasecurity/libbpfgo/pull/333)
- Wrap `bpf_prog_attach` and `bpf_prog_detach2` by
[@&#8203;mozillazg](https://github.com/mozillazg) in
[https://github.com/aquasecurity/libbpfgo/pull/335](https://github.com/aquasecurity/libbpfgo/pull/335)
- ci: running tests on multiple go versions by
[@&#8203;mozillazg](https://github.com/mozillazg) in
[https://github.com/aquasecurity/libbpfgo/pull/336](https://github.com/aquasecurity/libbpfgo/pull/336)
- libbpf: bump to v1.2.2 by
[@&#8203;geyslan](https://github.com/geyslan) in
[https://github.com/aquasecurity/libbpfgo/pull/342](https://github.com/aquasecurity/libbpfgo/pull/342)
- fix: vagrant image install by
[@&#8203;geyslan](https://github.com/geyslan) in
[https://github.com/aquasecurity/libbpfgo/pull/341](https://github.com/aquasecurity/libbpfgo/pull/341)
- Add SkipMemlockBump to NewModuleArgs by
[@&#8203;bobrik](https://github.com/bobrik) in
[https://github.com/aquasecurity/libbpfgo/pull/337](https://github.com/aquasecurity/libbpfgo/pull/337)
- fix: trim quote characters in osinfo by
[@&#8203;NDStrahilevitz](https://github.com/NDStrahilevitz) in
[https://github.com/aquasecurity/libbpfgo/pull/344](https://github.com/aquasecurity/libbpfgo/pull/344)
- helpers: handle non numeric kernel versions by
[@&#8203;NDStrahilevitz](https://github.com/NDStrahilevitz) in
[https://github.com/aquasecurity/libbpfgo/pull/345](https://github.com/aquasecurity/libbpfgo/pull/345)
- osinfo: add support for rhel by
[@&#8203;NDStrahilevitz](https://github.com/NDStrahilevitz) in
[https://github.com/aquasecurity/libbpfgo/pull/347](https://github.com/aquasecurity/libbpfgo/pull/347)
- osinfo: support additional alma linux id by
[@&#8203;NDStrahilevitz](https://github.com/NDStrahilevitz) in
[https://github.com/aquasecurity/libbpfgo/pull/348](https://github.com/aquasecurity/libbpfgo/pull/348)
- chore: increase timeout for selftests by
[@&#8203;geyslan](https://github.com/geyslan) in
[https://github.com/aquasecurity/libbpfgo/pull/349](https://github.com/aquasecurity/libbpfgo/pull/349)
- fix(selftest): handle arm64 function names by
[@&#8203;geyslan](https://github.com/geyslan) in
[https://github.com/aquasecurity/libbpfgo/pull/350](https://github.com/aquasecurity/libbpfgo/pull/350)
- dependabot add by
[@&#8203;gitworkflows](https://github.com/gitworkflows) in
[https://github.com/aquasecurity/libbpfgo/pull/351](https://github.com/aquasecurity/libbpfgo/pull/351)
- build(deps): bump github.com/stretchr/testify from 1.8.2 to 1.8.4 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/aquasecurity/libbpfgo/pull/353](https://github.com/aquasecurity/libbpfgo/pull/353)
- build(deps): bump actions/checkout from 2 to 3 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/aquasecurity/libbpfgo/pull/352](https://github.com/aquasecurity/libbpfgo/pull/352)
- chore: minor clang format and tidy adjustments by
[@&#8203;geyslan](https://github.com/geyslan) in
[https://github.com/aquasecurity/libbpfgo/pull/358](https://github.com/aquasecurity/libbpfgo/pull/358)
- chore: add helpers to dependabot by
[@&#8203;geyslan](https://github.com/geyslan) in
[https://github.com/aquasecurity/libbpfgo/pull/359](https://github.com/aquasecurity/libbpfgo/pull/359)
- build(deps): bump github.com/stretchr/testify from 1.8.0 to 1.8.4 in
/helpers by [@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/aquasecurity/libbpfgo/pull/360](https://github.com/aquasecurity/libbpfgo/pull/360)
- build(deps): bump golang.org/x/sys from 0.1.0 to 0.11.0 in /helpers by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/aquasecurity/libbpfgo/pull/361](https://github.com/aquasecurity/libbpfgo/pull/361)
- fix(selftest): kern_version logic by
[@&#8203;geyslan](https://github.com/geyslan) in
[https://github.com/aquasecurity/libbpfgo/pull/362](https://github.com/aquasecurity/libbpfgo/pull/362)
- fix(selftest): use channel for sync by
[@&#8203;geyslan](https://github.com/geyslan) in
[https://github.com/aquasecurity/libbpfgo/pull/364](https://github.com/aquasecurity/libbpfgo/pull/364)
- Split BPFMap API into managed and unmanaged by
[@&#8203;geyslan](https://github.com/geyslan) in
[https://github.com/aquasecurity/libbpfgo/pull/356](https://github.com/aquasecurity/libbpfgo/pull/356)
- fix(map): fix error wrap by
[@&#8203;geyslan](https://github.com/geyslan) in
[https://github.com/aquasecurity/libbpfgo/pull/368](https://github.com/aquasecurity/libbpfgo/pull/368)
- fix(helpers): lint err regarding return statement by
[@&#8203;geyslan](https://github.com/geyslan) in
[https://github.com/aquasecurity/libbpfgo/pull/369](https://github.com/aquasecurity/libbpfgo/pull/369)
- chore(github): add workflow test by
[@&#8203;geyslan](https://github.com/geyslan) in
[https://github.com/aquasecurity/libbpfgo/pull/370](https://github.com/aquasecurity/libbpfgo/pull/370)
- fix: `GetMap()` comment by
[@&#8203;geyslan](https://github.com/geyslan) in
[https://github.com/aquasecurity/libbpfgo/pull/371](https://github.com/aquasecurity/libbpfgo/pull/371)
- Map of maps by [@&#8203;geyslan](https://github.com/geyslan) in
[https://github.com/aquasecurity/libbpfgo/pull/366](https://github.com/aquasecurity/libbpfgo/pull/366)
- build(deps): bump golang.org/x/sys from 0.11.0 to 0.12.0 in /helpers
by [@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/aquasecurity/libbpfgo/pull/375](https://github.com/aquasecurity/libbpfgo/pull/375)
- build(deps): bump actions/checkout from 3 to 4 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/aquasecurity/libbpfgo/pull/376](https://github.com/aquasecurity/libbpfgo/pull/376)

#### New Contributors

- [@&#8203;bobrik](https://github.com/bobrik) made their first
contribution in
[https://github.com/aquasecurity/libbpfgo/pull/337](https://github.com/aquasecurity/libbpfgo/pull/337)
- [@&#8203;gitworkflows](https://github.com/gitworkflows) made their
first contribution in
[https://github.com/aquasecurity/libbpfgo/pull/351](https://github.com/aquasecurity/libbpfgo/pull/351)
- [@&#8203;dependabot](https://github.com/dependabot) made their first
contribution in
[https://github.com/aquasecurity/libbpfgo/pull/353](https://github.com/aquasecurity/libbpfgo/pull/353)

**Full Changelog**:
aquasecurity/libbpfgo@v0.4.9-libbpf-1.2.0...v0.5.0-libbpf-1.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/parca-dev/parca-agent).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants