-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kernel_features: fix tests for new KernelConfig #58
Conversation
This is the missing tests for the KernelConfig API we've discussed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these are failing for me:
[*] go test .
--- FAIL: TestGetKernelConfigValue (0.02s)
--- FAIL: TestGetKernelConfigValue/multiple_options_ok (0.01s)
kernel_features_test.go:75:
Error Trace: kernel_features_test.go:75
Error: Not equal:
expected: 0x2
actual : 0x0
Test: TestGetKernelConfigValue/multiple_options_ok
kernel_features_test.go:76:
Error Trace: kernel_features_test.go:76
Error: Not equal:
expected: <nil>(<nil>)
actual : *errors.errorString(&errors.errorString{s:"given option's value (CONFIG_TEST_BPF) is undefined"})
Test: TestGetKernelConfigValue/multiple_options_ok
kernel_features_test.go:75:
Error Trace: kernel_features_test.go:75
Error: Not equal:
expected: 0x2
actual : 0x0
Test: TestGetKernelConfigValue/multiple_options_ok
kernel_features_test.go:76:
Error Trace: kernel_features_test.go:76
Error: Not equal:
expected: <nil>(<nil>)
actual : *errors.errorString(&errors.errorString{s:"given option's value (CONFIG_TEST_BPF) is undefined"})
Test: TestGetKernelConfigValue/multiple_options_ok
--- FAIL: TestGetKernelConfigValue/string_value_ok (0.00s)
kernel_features_test.go:75:
Error Trace: kernel_features_test.go:75
Error: Not equal:
expected: "250"
actual : "1000"
Diff:
--- Expected
+++ Actual
@@ -1 +1 @@
-250
+1000
Test: TestGetKernelConfigValue/string_value_ok
kernel_features_test.go:75:
Error Trace: kernel_features_test.go:75
Error: Not equal:
expected: "250"
actual : "1000"
Diff:
--- Expected
+++ Actual
@@ -1 +1 @@
-250
+1000
Test: TestGetKernelConfigValue/string_value_ok
FAIL
FAIL github.com/aquasecurity/libbpfgo/helpers 0.140s
FAIL
All good here using the files from the testdata directory:
|
This is a preparation for a fix for: aquasecurity/tracee#851
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :-)
This is a preparation for a fix for: aquasecurity/tracee#851