Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checking if new operation in newbtfino succeeded #59

Merged
merged 1 commit into from
Aug 28, 2021
Merged

checking if new operation in newbtfino succeeded #59

merged 1 commit into from
Aug 28, 2021

Conversation

mtcherni95
Copy link
Contributor

We now check if new operation succeeded. so that in case it didn't we don't panic by calling DiscoverDistro().

The user of the NewBTFInfo function is responsible to check if the returned error is not nil.

rafaeldtinoco
rafaeldtinoco approved these changes Aug 28, 2021
View reviewed changes
Copy link
Contributor

@rafaeldtinoco rafaeldtinoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and for quick discussion about return &{} and new().

@rafaeldtinoco rafaeldtinoco merged commit c3b9bd6 into aquasecurity:main Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaeldtinoco rafaeldtinoco rafaeldtinoco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtcherni95 @rafaeldtinoco