Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add git and hg to docker image #33

Merged
merged 2 commits into from
Nov 3, 2022

Conversation

bobcallaway
Copy link
Contributor

When running the action against terraform containing modules sourced over git, the action would fail with the following message:

Example Terraform:

module "sigstore" {
  source = "git::https://github.com/sigstore/scaffolding.git//terraform/gcp/modules/sigstore?ref=130f8b87521ef67bf03486166385c36fff49ba4a"
  ...

Log message from tfsec-sarif-action:

terraform.parser.<root>.evaluator Failed to load module 'failed to download: error downloading 'https://github.com/sigstore/scaffolding.git?ref=130f8b87521ef67bf03486166385c36fff49ba4a': git must be available and on the PATH'. Maybe try 'terraform init'?

This commit adds the git and hg binaries to the underlying base image to ensure that the full module content is fetched and analyzed.

Signed-off-by: Bob Callaway bob.callaway@gmail.com

bobcallaway and others added 2 commits October 4, 2022 10:44
Signed-off-by: Bob Callaway <bcallaway@google.com>
Copy link
Contributor

@owenrumney owenrumney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@owenrumney owenrumney merged commit 21ded20 into aquasecurity:master Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants