Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forcing wget to use IPv4 #37

Merged
merged 8 commits into from
Nov 3, 2022
Merged

Conversation

jasonjanderson
Copy link
Contributor

Ran into an issue where the wget calls were failing with the following error:

+ '[' -n /github/workspace ']'
+ cd /github/workspace
+ TFSEC_VERSION=latest
+ '[' -n latest
/entrypoint.sh: line [14](https://github.com/jasonjanderson/terraform-test/actions/runs/3323368838/jobs/5493621746#step:5:15): [: missing `]'
++ grep -m 1 -o -E 'https://.+?tfsec-linux-amd64'
++ wget -q https://api.github.com/repos/aquasecurity/tfsec/releases/latest -O -
++ head -n1
wget: bad address 'api.github.com'
+ wget -O - -q ''
wget: bad address ''

Seems like the default busybox version of wget has issues when using a IPv6 network interface: https://stackoverflow.com/questions/66115118/wget-unable-to-resolve-host-address-github-com-inside-alpine-docker-image

Updated image to use the alpine version of wget and forcing IPv4 like what's suggested in the article.

Before change: https://github.com/jasonjanderson/terraform-test/actions/runs/3323368838/jobs/5493621746
After change: https://github.com/jasonjanderson/terraform-test/actions/runs/3324210862/jobs/5495510589

@CLAassistant
Copy link

CLAassistant commented Oct 26, 2022

CLA assistant check
All committers have signed the CLA.

@jasonjanderson
Copy link
Contributor Author

@owenrumney Tagging you since you have the most recent commit. Thoughts on this change?

@owenrumney owenrumney merged commit 8019886 into aquasecurity:master Nov 3, 2022
@owenrumney
Copy link
Contributor

thanks LGTM

haidaraM pushed a commit to haidaraM/tfsec-sarif-action that referenced this pull request Nov 7, 2022
@ilmax
Copy link

ilmax commented Sep 22, 2023

Hey @jasonjanderson is it me or this PR broke the install of tfsec to the latest version? Now it's hardcoded to v1.28.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants