docs: add usage info about action/cache for trivy databases
#397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriyLewen
changed the title
action/cache to trivy-dbaction/cache for trivy-db
|
How about trivy-java-db? |
|
I think there is no point in adding an example for each database, but I wrote about |
DmitriyLewen
changed the title
action/cache for trivy-dbaction/cache for trivy databases
simar7
reviewed
Oct 3, 2024
Comment on lines
+169
to
+173
| ## Trivy-db uses `0600` permissions. | ||
| ## But `action/cache` use `runner` user by default | ||
| ## So we need to change the permissions before caching the database. | ||
| - name: change permissions for trivy.db | ||
| run: sudo chmod 0644 ./cache/db/trivy.db |
There was a problem hiding this comment.
Shouldn't we change perms prior to running Trivy?
There was a problem hiding this comment.
there are 2 possible cases:
- cache doesn't contain DB - in this case we will save DB on
Post Restore trivy cachestep (see https://github.com/DmitriyLewen/test-trivy-action/actions/runs/11158340123/job/31014411967). So we can change permissions after Trivy work. - cache contains cache - in this case DB in cache already uses correct permissions.
simar7
approved these changes
Oct 8, 2024
knqyf263
pushed a commit
to knqyf263/trivy-action
that referenced
this pull request
Oct 8, 2024
…curity#397) * docs: add info about using `action/cache` for `trivy-db` * docs: add info about trivy-java-db and trivy-checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to the large number of
TOOMANYREQUESTSerrors - it makes sense to usecacheAdd information on how to use
action/cacheTest runs: