feat: add token for setup-trivy
#421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simar7
reviewed
Oct 24, 2024
action.yaml
Outdated
Comment on lines
116
to
122
| uses: aquasecurity/setup-trivy@v0.2.1 | ||
| uses: DmitriyLewen/setup-trivy@2df9f605c29dbee29f7c66a8151e3b97f0874f5d |
There was a problem hiding this comment.
Just a note that we should bump this to the next release when the other PR gets merged.
There was a problem hiding this comment.
Right. I used my fork to test the changes.
After setup-trivy is released - I will update this line.
There was a problem hiding this comment.
Updated in -9960a61
simar7
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are cases when we need to overwrite token for
actions/checkoutinsetup-trivy.e.g. GHES - #418, aquasecurity/setup-trivy#10
So we need to add a
token-setup-trivyinput to add the ability to override the defaulttoken.test runs:
token-setup-trivy- https://github.com/DmitriyLewen/test-trivy-action/actions/runs/11493317116token-setup-trivywith read perms only - https://github.com/DmitriyLewen/test-trivy-action/actions/runs/11493314425token-setup-trivyis not specified - https://github.com/DmitriyLewen/test-trivy-action/actions/runs/11493303718Related Issues
Related PRs
tokeninput and pingithub-server-urlsetup-trivy#12