Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detail configaudit info as prometheus metric #1302

Merged

Conversation

geoffrey1330
Copy link
Contributor

@geoffrey1330 geoffrey1330 commented Jun 15, 2023

Description

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).

@CLAassistant
Copy link

CLAassistant commented Jun 15, 2023

CLA assistant check
All committers have signed the CLA.

pkg/metrics/collector_test.go Outdated Show resolved Hide resolved
pkg/metrics/collector_test.go Outdated Show resolved Hide resolved
@chen-keinan
Copy link
Contributor

chen-keinan commented Jun 18, 2023

@geoffrey1330 looks good, the issue is not just on configaudit report its also require to add metric info support for other reports.

Are you planning to add it in a separate PR ?

@geoffrey1330
Copy link
Contributor Author

@geoffrey1330 looks good, the issue is not just on configaudit report its also require to add metric info support for other reports.

Are you planning to add it in a separate PR ?

Yes that will be much better If we create a new issue for the rest of the report

@chen-keinan
Copy link
Contributor

@geoffrey1330 looks good, the issue is not just on configaudit report its also require to add metric info support for other reports.
Are you planning to add it in a separate PR ?

Yes that will be much better If we create a new issue for the rest of the report

OK then create new issues for others report type and associate it to the issue above

@geoffrey1330
Copy link
Contributor Author

@geoffrey1330 looks good, the issue is not just on configaudit report its also require to add metric info support for other reports.
Are you planning to add it in a separate PR ?

Yes that will be much better If we create a new issue for the rest of the report

OK then create new issues for others report type and associate it to the issue above

Alright Will this PR be merged now?

@geoffrey1330 geoffrey1330 requested a review from chen-keinan June 18, 2023 09:57
@chen-keinan chen-keinan changed the title add trivy_configaudit_info metric Add detail configaudit info as prometheus metric Jun 18, 2023
@chen-keinan
Copy link
Contributor

@geoffrey1330 lgtm 🚀 thanks you for the contribution

chen-keinan
chen-keinan previously approved these changes Jun 18, 2023
@chen-keinan
Copy link
Contributor

chen-keinan commented Jun 18, 2023

@geoffrey1330 I have made some more tests and found issue with test, take a look above

@chen-keinan chen-keinan dismissed their stale review June 18, 2023 17:49

wait for test to pass

@chen-keinan
Copy link
Contributor

lgtm 🚀

@chen-keinan chen-keinan merged commit ce828a8 into aquasecurity:main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose detail info for config audit report as Prometheus metrics
3 participants