bugfix: rbac resource with capital letter name #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
When rbac resources is having capital letter in its name then trivy-operator throws error for creating its configaudit report OR rbac report. This happens bcoz capital letter name is not allowed in majority of the resources except rbac. To resolve this, we will make sure that trivy-operator doesnot try create report with capital letter, if capital letter comes then we generate report with hashvalue name - replace IsValidLabelValue to IsDNS1123Label which allows only lower case value other similar constraint on length resolve: aquasecurity#343
deven0t
force-pushed
the
deven-bugfix-configaudit-name
branch
from
c6fdfe9 to
975ea1b
Compare
|
@deven0t Thanks , lgtm 🚀 |
chen-keinan
approved these changes
Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rbac resources is having capital letter in its name then trivy-operator throws error for creating its configaudit report OR rbac report.
This happens bcoz capital letter name is not allowed in majority of the resources except rbac.
To resolve this, we will make sure that trivy-operator doesnot try create report with capital letter, if capital letter comes then we generate report with hashvalue name
resolve: #343