Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skip db update for clientserver mode #1440

Merged
merged 4 commits into from
Aug 17, 2023
Merged

feat: skip db update for clientserver mode #1440

merged 4 commits into from
Aug 17, 2023

Conversation

ahalay
Copy link
Contributor

@ahalay ahalay commented Aug 17, 2023

Description

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@ahalay ahalay requested a review from chen-keinan as a code owner August 17, 2023 11:29
@chen-keinan
Copy link
Contributor

chen-keinan commented Aug 17, 2023

@ahalay thank you for the contribution lgtm 🚀 , I have added on comment.
also need to run make generate-helm-docs and generate-all to generate relevant manifest and docs

chen-keinan
chen-keinan previously approved these changes Aug 17, 2023
deploy/helm/values.yaml Outdated Show resolved Hide resolved
@chen-keinan
Copy link
Contributor

@ahalay please see my comment

@chen-keinan chen-keinan merged commit f612674 into aquasecurity:main Aug 17, 2023
@ahalay
Copy link
Contributor Author

ahalay commented Aug 17, 2023

@chen-keinan Does it make sense to add --skip-java-db-update for SkipDBUpdate to already existing --skip-db-update?

return "--skip-db-update"

@chen-keinan
Copy link
Contributor

chen-keinan commented Aug 17, 2023

@ahalay java-db-update refer to java component index data not vulnerability.
it occur only when trivy cli detect jar files inside the container.
Skipping it functionality should be do en in a separate flag as it does a different thing from db-update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to skip DB update in ClientServer mode
2 participants