Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: non completed containers with invalid stacktrace #2107

Conversation

chen-keinan
Copy link
Contributor

Description

non completed containers with invalid stacktrace

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).

Signed-off-by: chenk <hen.keinan@gmail.com>
@github-actions github-actions bot added the bug label May 28, 2024
@chen-keinan chen-keinan merged commit f1dada8 into aquasecurity:main May 30, 2024
8 checks passed
@ymettier
Copy link

This PR will fix #2101 .

But isn't there a regression here ? If Trivy fails (like described in #2101 ) will there be any way to detect it ?

The stacktrace was a way to detect the problem and it is now removed.

@chen-keinan
Copy link
Contributor Author

chen-keinan commented May 30, 2024

@ymettier thanks for the input, I'll revert the change, after investigating the issue its look like root case related to latest changes with trivy logger, its under investigation.

@chen-keinan chen-keinan mentioned this pull request Jun 3, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stacktrace when scanning k8s containers and no info about the problem
2 participants