Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rootfs subcommand #794

Merged
merged 7 commits into from
Dec 20, 2022
Merged

Support rootfs subcommand #794

merged 7 commits into from
Dec 20, 2022

Conversation

bgoareguer
Copy link
Contributor

@bgoareguer bgoareguer commented Dec 15, 2022

Description

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@bgoareguer bgoareguer changed the title [WIP] Support rootfs subcommand Support rootfs subcommand Dec 16, 2022
@bgoareguer bgoareguer marked this pull request as ready for review December 16, 2022 12:32
@chen-keinan
Copy link
Contributor

@bgoareguer thank you for this contribution.
I wonder, rootfs and fs works exactly the same, setting , env variables, scan packages on fs and command syntax.
the only different is the subcommand rootfs vs fs would it make sense to reuse the fs code and just replace the sub command based on helm values, wdyt?

@chen-keinan chen-keinan self-requested a review December 20, 2022 06:55
@chen-keinan
Copy link
Contributor

LGTM 🚀

@chen-keinan chen-keinan merged commit 7bfc3aa into aquasecurity:main Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support rootfs sub-command
2 participants