-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING: add new classes for vulnerabilities #2541
Conversation
pkgs := map[string][]ftypes.Package{} | ||
for _, result := range report.Results { | ||
if result.Class == types.ClassOSPkg || result.Class == types.ClassLangPkg { | ||
pkgs[result.Target] = result.Packages | ||
} | ||
} | ||
|
||
for _, result := range report.Results { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these cycles look like the same, isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we have to take packages from report.Results
before writing the table output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a comment
1ed1d28
Description
This PR introduces new classes,
vuln-os-pkgs
andvuln-lang-pkgs
.Packages
andVulnerabilities
are stored separately.Before
There is a single target including both packages and vulnerabilities.
After
There are two targets for packages and vulnerabilities.
Checklist