fix: Fix --file-patterns flag #2625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #774 Signed-off-by: Liam Galvin <liam.galvin@aquasec.com>
owenrumney
approved these changes
Jul 29, 2022
pkg/fanal/handler/misconf/misconf.go
Outdated
| @@ -39,6 +39,7 @@ func init() { | |||
| const version = 1 | |||
|
|
|||
| type misconfPostHandler struct { | |||
| options artifact.Option | |||
There was a problem hiding this comment.
What if we only store options.MisconfScannerOption.FilePatterns here?
I think we don't need to keep all "options".
There was a problem hiding this comment.
Yeah, that's true, done 👍
DmitriyLewen
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2608
Signed-off-by: Liam Galvin liam.galvin@aquasec.com
Description
Fixes use of the
--file-patternsflag. Defsec detection is now overridden when a custom file pattern is provided for the file type.Related issues