fix(misconf): Allow quotes in Dockerfile WORKDIR when detecting relative dirs #2636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ative directories Resolves #2622 Signed-off-by: Liam Galvin <liam.galvin@aquasec.com>
liamg
changed the title
knqyf263
reviewed
Aug 1, 2022
| @@ -268,7 +268,7 @@ | |||
| "Class": "config", | |||
| "Type": "helm", | |||
| "MisconfSummary": { | |||
| "Successes": 34, | |||
| "Successes": 78, | |||
There was a problem hiding this comment.
Did you add a lot of checks for Kubernetes?
There was a problem hiding this comment.
Haha, yes! @josedonizetti added lots of CIS Benchmark checks in aquasecurity/defsec#720 and aquasecurity/defsec#721 :)
There was a problem hiding this comment.
Oh, cool👍 I just wanted to confirm that a number of Successes didn't jump by mistake. Thanks for confirming.
knqyf263
approved these changes
Aug 1, 2022
|
I'll wait for @owenrumney's review. |
owenrumney
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2622
Signed-off-by: Liam Galvin liam.galvin@aquasec.com
Description
Regular expression for WORKDIR used in the rego rule in defsec did not allow quotes - now it does.
Related issues