feat: Support passing value overrides for configuration checks #2679
Conversation
owenrumney
changed the title
owenrumney
changed the title
pkg/flag/misconf_flags.go
Outdated
| @@ -53,6 +53,36 @@ var ( | |||
| Value: []string{}, | |||
| Usage: "Rego namespaces", | |||
| } | |||
| HelmValuesFileFlag = Flag{ | |||
| Name: "helm-values", | |||
| ConfigName: "misconfiguration.helm-values", | |||
There was a problem hiding this comment.
Currently, the config format is like the following.
misconfiguration:
helm-values:
- values-prod.yaml
helm-set:
- key1=val1
- key2=val2
tf-vars:
- foo.tfvars
- bar.tfvars
Do you think grouping languages is too nested as below? I'm not sure which is better. I just would like to hear your thought.
misconfiguration:
helm:
values:
- values-prod.yaml
set:
- key1=val1
- key2=val2
terraform:
vars:
- foo.tfvars
- bar.tfvars
There was a problem hiding this comment.
Helm uses --set but I changed it to --helm-set to avoid collisions in the future with other configs that might be in the same files system that also wanted a --set
I like personally like how explicit the second config block is and I don't think it's too nested. @liamg - do you have an opinion?
There was a problem hiding this comment.
So I assume I would just change the ConfigName to misconfiguration.helm.values to achieve the second config block?
There was a problem hiding this comment.
So I assume I would just change the ConfigName to misconfiguration.helm.values to achieve the second config block?
Yes. misconfiguration.helm.values should work.
There was a problem hiding this comment.
Changed to misconfiguration.helm.xxxx and misconfiguration.terraform.xxx
owenrumney
force-pushed
the
owenr-passthrough-var-files
branch
from
912c29e
to
014159f
Compare
|
Could you also update this page? |
Resolves #2276 Signed-off-by: Owen Rumney <owen.rumney@aquasec.com>
be more explict in the configuration block to separate the languages Signed-off-by: Owen Rumney <owen.rumney@aquasec.com>
Signed-off-by: Owen Rumney <owen.rumney@aquasec.com>
owenrumney
force-pushed
the
owenr-passthrough-var-files
branch
from
b0f91b6
to
13e4d66
Compare
Updated this with the possible config settings |
|
Cool. Thanks. |
Description
Add support for passing variable files for configuration scanning
Terraform
Pass
--tf-varsto override default terraform valuesHelm
Support standard helm install flags (with the
helmprefix)--helm-set--helm-values--helm-set-string--helm-set-fileRelated issues
Remove this section if you don't have related PRs.
Checklist