Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: specify the type when verifying an attestation #2697

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

otms61
Copy link
Collaborator

@otms61 otms61 commented Aug 11, 2022

Description

Specify the type when verifying an attestation because Cosign command will fail without the type option.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@otms61 otms61 requested a review from knqyf263 as a code owner August 11, 2022 09:51
Comment on lines +156 to +160
Cosign can generate key pairs and use them for signing and verification. After you run the following command, you will get a public and private key pair. Read more about [how to generate key pairs](https://docs.sigstore.dev/cosign/key-generation).

```bash
$ cosign generate-key-pair
```
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added examples of commands so viewers don't have to look at other sites.
This is the same modification I made to the SBOM.
8cb9cf8

@knqyf263 knqyf263 merged commit f8edda8 into aquasecurity:main Aug 11, 2022
@otms61 otms61 deleted the fix_verify_attest_docs branch August 11, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants