chore(go): remove experimental FS API usage in Wasm #3299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
mathetake
changed the title
mathetake
changed the title
knqyf263
reviewed
Dec 14, 2022
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
mathetake
requested review from
knqyf263 and
codefromthecrypt
and removed request for
knqyf263 and
codefromthecrypt
codefromthecrypt
approved these changes
Dec 16, 2022
There was a problem hiding this comment.
the lock is at the right place for the filesystem concern. the normal parallel concerns still exist, but can be addressed later (e.g. the other function calls aren't locked and they could end up malloc etc concurrently, but that isn't the heart of this issue)
knqyf263
approved these changes
Dec 18, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Takeshi Yoneda takeshi@tetrate.io
Description
Previously, wazero introduced context-based FS (tetratelabs/wazero#571) and used in Trivy to change the underlying file system anytime it calls Analyze API. But it came with the runtime overhead and there's actually an easy way to achieve the same thing without that experimental API.
This PR, hence, removes the usage of the experimental API by introducing the wrapper over memfs.FS which can change the underlying file system in response to the Analyze calls.