Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use debug message for post-analyze errors #4037

Merged

Conversation

DmitriyLewen
Copy link
Contributor

Description

Use debug message for post-analyze errors as for AnalyzeFile.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen marked this pull request as ready for review April 12, 2023 08:27
@knqyf263
Copy link
Collaborator

After retaking a look at this PR, another concern came to my mind. What if there are 100 valid JAR files and one broken JAR file? Do we not show 100 valid JAR files now?

@DmitriyLewen
Copy link
Contributor Author

@knqyf263 hm... you are right. I will try to fix this.

@DmitriyLewen
Copy link
Contributor Author

@knqyf263
I added changes. Take a look, when you have time, please

@beltran-rubo
Copy link

Any progress or ETA for this one? Thanks

@chilcano
Copy link

Any progress on this?
I'm facing same issues and I would like to use this updated Trivy version soon in my pipelines.
Appreciate your support.
Regards.

@knqyf263 knqyf263 merged commit 845ae31 into aquasecurity:main Apr 27, 2023
@knqyf263 knqyf263 added this to the v0.41.0 milestone Apr 27, 2023
@knqyf263
Copy link
Collaborator

Will be included in v0.41.0

@knqyf263 knqyf263 removed this from the v0.41.0 milestone Apr 27, 2023
@DmitriyLewen DmitriyLewen deleted the warning-for-post-analyzer-errors branch May 10, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trivy breaks when it encounters a license file with an invalid extension Ignore Invalid Zip Files
4 participants