Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(java): fix overwriting project props in pom.xml #4498

Merged
merged 2 commits into from
May 31, 2023

Conversation

DmitriyLewen
Copy link
Contributor

Description

See #205

Related issues

Related Discussions

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this May 30, 2023
@DmitriyLewen DmitriyLewen marked this pull request as ready for review May 30, 2023 08:44
@knqyf263
Copy link
Collaborator

This commit includes aquasecurity/go-dep-parser@dd6d97c and aquasecurity/go-dep-parser@555b677 as well, right? We should list those issues or open PRs separately.

@DmitriyLewen
Copy link
Contributor Author

Right. I missed that. Thanks!

I created #4501 and #4502 to make it easier for us to find these changes if needed.

@DmitriyLewen DmitriyLewen marked this pull request as draft May 30, 2023 09:47
@knqyf263
Copy link
Collaborator

knqyf263 commented May 31, 2023

We've merged #4501 and #4502. Is this the next?

@DmitriyLewen DmitriyLewen marked this pull request as ready for review May 31, 2023 07:46
@DmitriyLewen
Copy link
Contributor Author

Right. PR is ready to merge.

@knqyf263 knqyf263 merged commit d474040 into aquasecurity:main May 31, 2023
@DmitriyLewen DmitriyLewen deleted the fix/pom-parent-props branch June 1, 2023 05:03
AnaisUrlichs pushed a commit to AnaisUrlichs/trivy that referenced this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Miscalculated versions of transitive dependencies in maven project
2 participants