Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(misconf): terraform relative paths #4571

Merged
merged 8 commits into from
Jun 8, 2023
Merged

fix(misconf): terraform relative paths #4571

merged 8 commits into from
Jun 8, 2023

Conversation

knqyf263
Copy link
Collaborator

@knqyf263 knqyf263 commented Jun 6, 2023

Description

#4556 introduced a regression regarding Terraform relative paths, but tests didn't fail. This PR adds a test case for relative paths.

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263 knqyf263 self-assigned this Jun 6, 2023
@knqyf263 knqyf263 requested a review from simar7 June 6, 2023 19:02
@knqyf263 knqyf263 marked this pull request as ready for review June 6, 2023 19:02
@knqyf263
Copy link
Collaborator Author

knqyf263 commented Jun 6, 2023

@simar7 This PR just adds a test and fixes a regression. Can you please take a look?

simar7
simar7 approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! lgtm, thanks for simplifying some of the test setup as well.

@knqyf263 knqyf263 merged commit 8ca1bfd into aquasecurity:main Jun 8, 2023
@knqyf263 knqyf263 deleted the fix/relative_path branch June 8, 2023 08:25
AnaisUrlichs pushed a commit to AnaisUrlichs/trivy that referenced this pull request Aug 10, 2023
@knqyf263 @AnaisUrlichs
fix(misconf): terraform relative paths (aquasecurity#4571)
4cea9d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simar7 simar7 simar7 approved these changes

Assignees

@knqyf263 knqyf263

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knqyf263 @simar7