Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sbom): add missed primaryURL and source severity for CycloneDX #5399

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented Oct 18, 2023

Description

See #5372 for more details.

Changes:

  • for table and json formats we use primaryURL. But CycloneDX doesn't have equivalent field. We can add primaryURL into advisories array.
  • Save package-specific severity in VendorSeverity (for CycloneDX, there may be case where user can't understand why we use this severity).

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Oct 18, 2023
@DmitriyLewen DmitriyLewen marked this pull request as ready for review October 18, 2023 08:59
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263
Copy link
Collaborator

@DmitriyLewen I've refactored a bit. Please let me know if I'm doing something wrong.

@DmitriyLewen
Copy link
Contributor Author

@knqyf263 LGTM. Thanks for help!

@knqyf263 knqyf263 added this pull request to the merge queue Oct 19, 2023
Merged via the queue into aquasecurity:main with commit 6040d9f Oct 19, 2023
12 checks passed
@DmitriyLewen DmitriyLewen deleted the fix/add-sourse-severity-and-primary-url branch November 20, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(report): different values in vulnerability fields (Severity, links) for table, json and cyclonedx formats
2 participants