Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(terraform): ignore resources by nested attributes #6302

Merged
merged 6 commits into from
Mar 29, 2024
Merged

feat(terraform): ignore resources by nested attributes #6302

merged 6 commits into from
Mar 29, 2024

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Mar 12, 2024 •
edited
Loading

Description

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin marked this pull request as ready for review March 15, 2024 10:02
@nikpivkin nikpivkin requested a review from simar7 as a code owner March 15, 2024 10:02
@simar7 simar7 added this pull request to the merge queue Mar 29, 2024
Merged via the queue into aquasecurity:main with commit 29dee32 Mar 29, 2024
17 checks passed
@nikpivkin nikpivkin deleted the tf-ignore-attrs branch March 29, 2024 05:02
@itaysk
Copy link
Contributor

itaysk commented Apr 9, 2024

don't we need to update the docs?

@nikpivkin
Copy link
Contributor Author

@itaysk https://github.com/aquasecurity/trivy/pull/6302/files#diff-27a4cf648b57a6aad62225b17605a34b1e7b47b97925e1e24a311db4e22cc57f

@itaysk
Copy link
Contributor

itaysk commented Apr 9, 2024

ah I missed it, thanks!

fl0pp5 pushed a commit to altlinux/trivy that referenced this pull request May 6, 2024
@nikpivkin @fl0pp5
feat(terraform): ignore resources by nested attributes (aquasecurity#…
1890272 
…6302)
@aqua-bot aqua-bot mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simar7 simar7 simar7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(misconf): Ignoring specific values for terraform files when using for_each
3 participants
@nikpivkin @itaysk @simar7