Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(misconf): Parse JSON k8s manifests properly #6490

Merged
merged 2 commits into from
Apr 19, 2024
Merged

fix(misconf): Parse JSON k8s manifests properly #6490

merged 2 commits into from
Apr 19, 2024

Conversation

simar7
Copy link
Member

@simar7 simar7 commented Apr 13, 2024

Description

Improves k8s JSON manifest parsing

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@simar7 simar7 self-assigned this Apr 13, 2024
@simar7 simar7 marked this pull request as ready for review April 17, 2024 04:26
@simar7 simar7 removed the request for review from knqyf263 April 17, 2024 04:26
@simar7 simar7 requested a review from nikpivkin April 18, 2024 04:27
nikpivkin
nikpivkin approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@nikpivkin nikpivkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simar7 simar7 added this pull request to the merge queue Apr 19, 2024
Merged via the queue into main with commit 9b7d713 Apr 19, 2024
12 checks passed
@simar7 simar7 deleted the fix-k8s-json-parsing branch April 19, 2024 01:38
fl0pp5 pushed a commit to altlinux/trivy that referenced this pull request May 6, 2024
@simar7 @fl0pp5
fix(misconf): Parse JSON k8s manifests properly (aquasecurity#6490)
96b8285
fl0pp5 added a commit to altlinux/trivy that referenced this pull request May 28, 2024
@fl0pp5
fix(misconf): Parse JSON k8s manifests properly (aquasecurity#6490)
16e72ab
@aqua-bot aqua-bot mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikpivkin nikpivkin nikpivkin approved these changes

Assignees

@simar7 simar7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(misconf): YAML and JSON inputs of same file yield different output formats from Trivy
2 participants
@simar7 @nikpivkin