Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(k8s): enhance k8s scan log #6997

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

haojingcn
Copy link
Contributor

Description

Discussed in #6932

In short, progress bar may lead someone(like me) confused. It show the download progress or scan image progress or scan K8s progress.

Related issues

Related PRs

  • #XXX
  • #YYY

Remove this section if you don't have related PRs.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@haojingcn haojingcn requested a review from chen-keinan as a code owner June 22, 2024 15:04
@CLAassistant
Copy link

CLAassistant commented Jun 22, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

This PR is stale because it has been labeled with inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Aug 22, 2024
@afdesk
Copy link
Contributor

afdesk commented Aug 26, 2024

Honestly, the progress bar confused me too.
so maybe it makes sense to merge this PR.

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Aug 27, 2024
@itaysk itaysk requested review from afdesk and removed request for chen-keinan August 27, 2024 12:41
@afdesk
Copy link
Contributor

afdesk commented Aug 28, 2024

@haojingcn LGTM! thanks!

@afdesk afdesk self-requested a review August 28, 2024 06:21
@afdesk
Copy link
Contributor

afdesk commented Aug 28, 2024

@haojingcn The idea is good, but i see a sample.
what if we remove additoinal text: (nextline show the progress)?
it'll look like Downloading DB:

2024-08-28T12:21:35+06:00	INFO	[db] Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
52.46 MiB / 52.46 MiB [----------------------------------------------------------------------------------------------------------------------------------------] 100.00% 3.8

pkg/k8s/commands/run.go Outdated Show resolved Hide resolved
Copy link

This PR is stale because it has been labeled with inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Oct 28, 2024
Co-authored-by: afdesk <work@afdesk.com>
@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Nov 7, 2024
@afdesk
Copy link
Contributor

afdesk commented Nov 11, 2024

@haojingcn LGTM! thanks!

@afdesk afdesk changed the title fix(k8s): enhance k8s scan log chore(k8s): enhance k8s scan log Nov 11, 2024
@afdesk afdesk added this pull request to the merge queue Nov 11, 2024
Merged via the queue into aquasecurity:main with commit bdfcc19 Nov 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add log message for avoid confusion about the progress bar
3 participants