Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(misconf): pass options to Rego scanner as is #7529

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Sep 17, 2024

Description

Now each configuration scanner accepts Rego scanner specific options and stores them in its fields for subsequent initialization of the Rego scanner. Instead, all Rego-specific options can be passed directly to the Rego scanner. This will make it easier to add new Rego options.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
@simar7 simar7 marked this pull request as ready for review September 17, 2024 22:34
@simar7
Copy link
Member

simar7 commented Sep 17, 2024

lgtm @nikpivkin can we merge this in? Or are you still working on it, asking since it was marked as a draft.

@nikpivkin
Copy link
Contributor Author

@simar7 I just haven't added a description yet.

@simar7 simar7 added this pull request to the merge queue Sep 18, 2024
Merged via the queue into aquasecurity:main with commit dbd2dd6 Sep 18, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants