Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cvss v4 score and vector in scan response #7968

Merged
merged 4 commits into from
Nov 21, 2024
Merged

feat: add cvss v4 score and vector in scan response #7968

merged 4 commits into from
Nov 21, 2024

Conversation

gshanbhag525
Copy link
Contributor

Description

NVD (NIST) has started publishing cvss v4 for CVE.
eg. CVE-2024-7450,CVE-2024-7451,CVE-2024-7452
Currently trivy doesnot return cvssv4 score, vector in scan response.
This PR handles it.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@gshanbhag525
feat: add cvssv4 score, vector in rpc struct
690617e 
return cvssv4 score, vector when returning scan response in trivy.
@gshanbhag525
feat: add cvssv4 score, vector in cvss map
278b55d 
add cvssv4 score, vector in cvss map protobuf
@gshanbhag525
feat: add test for cvssv4 score, vector in convert
7e5a49a
knqyf263
knqyf263 reviewed Nov 21, 2024
View reviewed changes
rpc/common/service.pb.go Outdated
// protoc-gen-go v1.34.0
// protoc v3.19.4
// protoc-gen-go v1.34.2
// protoc v3.17.3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you generate it? Did you run mage protoc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used a local protoc. If needed, I can run mage protoc.
can you please tell me, how it needs to be run.

Copy link
Collaborator

@knqyf263 knqyf263 Nov 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use the same version unless we explicitly change the protoc version to avoid unexpected problems.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed , please review.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

knqyf263
knqyf263 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knqyf263 knqyf263 enabled auto-merge November 21, 2024 10:29
@knqyf263 knqyf263 added this pull request to the merge queue Nov 21, 2024
Merged via the queue into aquasecurity:main with commit e0f2054 Nov 21, 2024
12 checks passed
@aqua-bot aqua-bot mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gshanbhag525 @knqyf263