-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encoding::CompatibilityError #5
base: master
Are you sure you want to change the base?
Conversation
This project was originally written for ruby 1.8 and I've never really spent the time to properly address some of these issues. I don't think forcing the encoding to UTF8 is the way to go though - different MIME parts could conceivably have different encodings, as would be noted in the Content-Type charset. |
+1 for merging this fix |
+1 for merge |
+1 on merge here. I just came to the same conclusion as the OP for the solution and implemented it locally, but in lieu of a better solution, perhaps this one should be adopted? |
I did some digging on this and I found that .eml files are encoded in ascii while msg files support multiple encodings. It appears the proper fix is to change the encodings of the outputs to ascii so that the resulting eml file is 100% ascii. I'm going to work on a different PR. |
Original error message:
I ran through your how-to in IRB and traced it to line 109 of
lib/mime
Changing
to
seems to have addressed the issue.
I'll attach a pull request to this issue tomorrow morning with my change.