Fix content types for XML responses (#153)

* ensure xml has content header set * import bluebird
arafato · Feb 5, 2018 · c2dbec6 · c2dbec6
1 parent fa71d5a
commit c2dbec6
Show file tree

Hide file tree

Showing 7 changed files with 19 additions and 7 deletions.
diff --git a/lib/AzuriteQueue.js b/lib/AzuriteQueue.js
@@ -4,7 +4,8 @@ const express = require('express'),
     env = require('./core/env'),
     bodyParser = require('body-parser'),
     morgan = require('morgan'),
-    cli = require('./core/cli');
+    cli = require('./core/cli'),    
+    BbPromise = require('bluebird');
 
 class AzuriteQueue {
     constructor() {

diff --git a/lib/actions/blob/GetContainerAcl.js b/lib/actions/blob/GetContainerAcl.js
@@ -13,7 +13,8 @@ class GetContainerAcl {
             .then((response) => {
                 if (response.proxy.original.access !== 'private') {
                     response.addHttpProperty(N.BLOB_PUBLIC_ACCESS, response.proxy.original.access);
-                }
+                }                
+                response.addHttpProperty(N.CONTENT_TYPE, 'application/xml');
                 res.set(response.httpProps);
                 let xml = js2xmlparser.parse('SignedIdentifiers', response.proxy.original.signedIdentifiers || {});
                 xml = xml.replace(`<?xml version='1.0'?>`, `<?xml version="1.0" encoding="utf-8"?>`);

diff --git a/lib/actions/queue/GetMessages.js b/lib/actions/queue/GetMessages.js
@@ -3,7 +3,8 @@
 const QueueManager = require('./../../core/queue/QueueManager'),
     QueueMessagesListXmlModel = require('./../../xml/queue/QueueMessageList').QueueMessageListXmlModel,
     QueueMessageXmlModel = require('./../../xml/queue/QueueMessageList').QueueMessageXmlModel,
-    AzuriteQueueResponse = require('./../../model/queue/AzuriteQueueResponse');
+    AzuriteQueueResponse = require('./../../model/queue/AzuriteQueueResponse'),
+    N = require('./../../core/HttpHeaderNames');
 
 class GetMessages {
     constructor() {
@@ -26,6 +27,7 @@ class GetMessages {
         }
         const xmlBody = model.toXml();
         const response = new AzuriteQueueResponse();
+        response.addHttpProperty(N.CONTENT_TYPE, 'application/xml');
         res.set(response.httpProps);
         res.status(200).send(xmlBody);
     }

diff --git a/lib/actions/queue/GetQueueAcl.js b/lib/actions/queue/GetQueueAcl.js
@@ -2,7 +2,8 @@
 
 const QueueManager = require('./../../core/queue/QueueManager'),
     js2xmlparser = require("js2xmlparser"),
-    AzuriteQueueResponse = require('./../../model/queue/AzuriteQueueResponse');
+    AzuriteQueueResponse = require('./../../model/queue/AzuriteQueueResponse'),
+    N = require('./../../core/HttpHeaderNames');
 
 class GetQueueAcl {
     constructor() {
@@ -14,6 +15,7 @@ class GetQueueAcl {
         let xml = js2xmlparser.parse('SignedIdentifiers', signedIdentifiers || {});
         xml = xml.replace(`<?xml version='1.0'?>`, `<?xml version="1.0" encoding="utf-8"?>`);
         const response = new AzuriteQueueResponse();
+        response.addHttpProperty(N.CONTENT_TYPE, 'application/xml');
         res.set(response.httpProps);
         res.status(200).send(xml);
     }

diff --git a/lib/actions/queue/ListQueues.js b/lib/actions/queue/ListQueues.js
@@ -3,7 +3,8 @@
 const QueueManager = require('./../../core/queue/QueueManager'),
     QueueListXmlModel = require('./../../xml/queue/QueueList').QueueList,
     QueueXmlModel = require('./../../xml/queue/QueueList').Queue,
-    AzuriteQueueResponse = require('./../../model/queue/AzuriteQueueResponse');
+    AzuriteQueueResponse = require('./../../model/queue/AzuriteQueueResponse'),
+    N = require('./../../core/HttpHeaderNames');
 
 class ListQueues {
     constructor() {
@@ -26,6 +27,7 @@ class ListQueues {
         } 
         const xmlString = xmlModel.toXml();
         const response = new AzuriteQueueResponse();
+        response.addHttpProperty(N.CONTENT_TYPE, 'application/xml');
         res.set(response.httpProps);
         res.status(200).send(xmlString);
     }

diff --git a/lib/actions/queue/PeekMessages.js b/lib/actions/queue/PeekMessages.js
@@ -3,7 +3,8 @@
 const QueueManager = require('./../../core/queue/QueueManager'),
     QueueMessagesListXmlModel = require('./../../xml/queue/QueueMessageList').QueueMessageListXmlModel,
     QueueMessageXmlModel = require('./../../xml/queue/QueueMessageList').QueueMessageXmlModel,
-    AzuriteQueueResponse = require('./../../model/queue/AzuriteQueueResponse');
+    AzuriteQueueResponse = require('./../../model/queue/AzuriteQueueResponse'),
+    N = require('./../../core/HttpHeaderNames');
 
 class PeekMessages {
     constructor() {
@@ -24,6 +25,7 @@ class PeekMessages {
         }
         const xmlBody = model.toXml();
         const response = new AzuriteQueueResponse();
+        response.addHttpProperty(N.CONTENT_TYPE, 'application/xml');
         res.set(response.httpProps);
         res.status(200).send(xmlBody);
     }

diff --git a/lib/actions/queue/PutMessage.js b/lib/actions/queue/PutMessage.js
@@ -3,7 +3,8 @@
 const QueueManager = require('./../../core/queue/QueueManager'),
     QueueMessagesListXmlModel = require('./../../xml/queue/QueueMessageList').QueueMessageListXmlModel,
     QueueMessageXmlModel = require('./../../xml/queue/QueueMessageList').QueueMessageXmlModel,
-    AzuriteQueueResponse = require('./../../model/queue/AzuriteQueueResponse');
+    AzuriteQueueResponse = require('./../../model/queue/AzuriteQueueResponse'),
+    N = require('./../../core/HttpHeaderNames');
 
 class PutMessage {
     constructor() {
@@ -23,6 +24,7 @@ class PutMessage {
             }));
         const xmlBody = model.toXml();
         const response = new AzuriteQueueResponse();
+        response.addHttpProperty(N.CONTENT_TYPE, 'application/xml');
         res.set(response.httpProps);
         res.status(201).send(xmlBody);
     }