This repository has been archived by the owner on Mar 22, 2018. It is now read-only.
Return queue length with metadata #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great @leafnode , thanks a lot! Will merge tomorrow when I'm back in coding mode ;-) |
arafato
reviewed
Dec 14, 2017
| response = new AzuriteQueueResponse(); | ||
| response.addMetaProps(metaProps); | ||
| response.addMetaProps(metaProps, queueLength); |
There was a problem hiding this comment.
@leafnode can you please use response.addHttpProperty('x-ms-approximate-messages-count', queueLength);
There was a problem hiding this comment.
Sure! Actually, adding more parameters to the signature looked bad, but I wanted to keep this in one place and didn't have much time for deeper refactoring. But if adding it in another line is fine - I'm good with it.
arafato
reviewed
Dec 14, 2017
| Object.keys(metaProps).forEach((key) => { | ||
| this.addHttpProperty(`x-ms-meta-${key}`, metaProps[key]); | ||
| }); | ||
| this.addHttpProperty(`x-ms-approximate-messages-count`, queueLength); |
There was a problem hiding this comment.
@leafnode and remove this line and switch back to original signature? Thanks!
|
Great, thanks a lot @leafnode ! Just merged and will be publishing as v1.8.1 soon. |
arafato
added a commit
that referenced
this pull request
Dec 15, 2017
|
Cobos Franco, inc. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added feature from the queue API: returning queue length with the metadata.