This repository has been archived by the owner on Mar 22, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two issues with the CORS implementation in azurite.
Without this, CORS doesn't work when testing on azurite even though it works when testing on the live blobstore. I'm using azurite master on OSX with node
v8.4.0
.The first issue can be reproduced by using the script below which will result in a failed destructuring assignment
“TypeError: Cannot match against 'undefined' or 'null’.”
The second issue can only be reproduced when testing CORS from a browser and is due to the fact that azurite wouldn't set the
Access-Control-Allow-Headers
on its response to the preflight request, making the browser believe CORS is disallowed.