Payroll: remove terminated storage and change exist modifier for activeness check #610
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @lmcorbalan @bingen
Changes the
employeeExists
modifier to instead check if an employee is still active (their end date hasn't been reached).This allows the app to:
terminated
storage for each employee, as invokingterminateEmployeeNow()
twice in the same block will fail (employee is only active if their end date hasn't been reached)Note that this does allow you to "terminate" an employee multiple times, if you set their end date in the future. I'd argue this is a terminology problem though (see below).
Further potential changes:
terminateEmployeeNow()
makes sense, butterminateEmployee()
should be changed tosetEmployeeEndDate()
so that its intention is more clearTodo:
setEmployeeEndDate()