Feat/external txs

package.json

@@ -26,7 +26,7 @@
   "dependencies": {
     "@aragon/templates-tokens": "^1.2.1",
     "@aragon/ui": "^0.40.1",
-    "@aragon/wrapper": "^5.0.0-rc.14",
+    "@aragon/wrapper": "^5.0.0-rc.15",
     "@babel/polyfill": "^7.0.0",
     "@sentry/browser": "^5.5.0",
     "@ungap/event-target": "^0.1.0",

src/components/SignerPanel/ActionPathsContent.js

@@ -12,6 +12,8 @@ const RADIO_ITEM_TITLE_LENGTH = 30
 class ActionPathsContent extends React.Component {
   static propTypes = {
     direct: PropTypes.bool.isRequired,
+    installed: PropTypes.bool.isRequired,
+    external: PropTypes.bool.isRequired,
     intent: PropTypes.object.isRequired,
     dao: PropTypes.string.isRequired,
     onSign: PropTypes.func.isRequired,
@@ -173,8 +175,10 @@ class ActionPathsContent extends React.Component {
   }
   render() {
     const {
+      installed,
       intent,
       direct,
+      external,
       paths,
       pretransaction,
       signingEnabled,
@@ -239,6 +243,15 @@ class ActionPathsContent extends React.Component {
             </Info.Action>
           </div>
         )}
+        {external && (
+          <div css="margin-top: 20px">
+            <Info.Alert title="Warning">
+              {installed
+                ? `Be aware that this is an attempt to execute a transaction on another app that is installed in this organization. You may want to double check that app's functionality before proceeding.`
+                : `Be aware that this is an attempt to execute a transaction on an *external contract* that has not been reviewed or audited. This means that it might behave unexpectedly. Please *be sure your trust this contract* before proceeding.`}
+            </Info.Alert>
+          </div>
+        )}
         <SignerButton onClick={this.handleSign} disabled={!signingEnabled}>
           Create transaction
         </SignerButton>

src/components/SignerPanel/ConfirmTransaction.js

@@ -6,6 +6,8 @@ import ImpossibleContent from './ImpossibleContent'
 const ConfirmTransaction = ({
   direct,
   intent,
+  installed,
+  external,
   dao,
   onClose,
   onSign,
@@ -20,9 +22,11 @@ const ConfirmTransaction = ({
 
   return possible ? (
     <ActionPathsContent
-      intent={intent}
       direct={direct}
       dao={dao}
+      external={external}
+      installed={installed}
+      intent={intent}
       onSign={onSign}
       paths={paths}
       pretransaction={pretransaction}
@@ -36,7 +40,9 @@ const ConfirmTransaction = ({
 
 ConfirmTransaction.propTypes = {
   direct: PropTypes.bool.isRequired,
+  installed: PropTypes.bool.isRequired,
   intent: PropTypes.object.isRequired,
+  external: PropTypes.bool.isRequired,
   dao: PropTypes.string,
   onClose: PropTypes.func.isRequired,
   onSign: PropTypes.func.isRequired,

src/components/SignerPanel/SignerPanel.js

@@ -107,14 +107,18 @@ class SignerPanel extends React.PureComponent {
   // This is a temporary method to reshape the transaction bag
   // to the future format we expect from Aragon.js
   stateFromTransactionBag(bag) {
-    const { path, transaction } = bag
+    const { external, path, transaction } = bag
     const decoratedPaths = path.map(path => ({
       ...path,
       name: getAppName(this.props.apps, path.to),
     }))
 
     return {
       intent: (transaction && this.transactionIntent(bag)) || {},
+      external: !!external,
+      installed: this.props.apps.some(
+        ({ proxyAddress }) => proxyAddress === transaction.to
+      ),
       directPath: decoratedPaths.length === 1,
       actionPaths: decoratedPaths.length ? [decoratedPaths] : [],
       pretransaction: (transaction && transaction.pretransaction) || null,
@@ -297,6 +301,8 @@ class SignerPanel extends React.PureComponent {
       actionPaths,
       pretransaction,
       status,
+      external,
+      installed,
     } = this.state
 
     const isTransaction = isTxSignerStatus(status)
@@ -344,6 +350,8 @@ class SignerPanel extends React.PureComponent {
                             <ConfirmTransaction
                               dao={dao}
                               direct={directPath}
+                              external={external}
+                              installed={installed}
                               intent={intent}
                               onClose={this.handleSignerClose}
                               onSign={this.handleSign}